yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

The patch was abandoned a long time ago and now we have this:
https://review.openstack.org/#/c/57774/

** Changed in: nova
       Status: In Progress => Won't Fix

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1182002

Title:
  stop lpar method is not properly timing out

Status in OpenStack Compute (Nova):
  Won't Fix

Bug description:
  The nova/virt/powervm/operator.py contains a method to stop the lpar.

      def stop_lpar(self, instance_name, timeout=30):
          """Stop a running LPAR.

          :param instance_name: LPAR instance name
          :param timeout: value in seconds for specifying
                          how long to wait for the LPAR to stop
          """
          cmd = self.command.chsysstate('-r lpar -o shutdown --immed -n %s' %
                                        instance_name)
          self.run_vios_command(cmd)

          # poll instance until stopped or raise exception
          lpar_obj = self.get_lpar(instance_name)
          .
          .
          .

  The problem is the code does not check for timeout until after
  chsysstate returns.  However, chsysstate does not return until the
  command completes which may exceed the timeout value.  The solution is
  to spawn a new thread for the run_vios_command so that you can
  properly check if it has timed out.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1182002/+subscriptions