← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1257273] [NEW] Glance download fails when size is 0

 

Public bug reported:

Glance images are not being fetched by glance's API v1 when the size is
0. There are 2 things wrong with this behaviour:

1) Active images should always be ready to be downloaded, regardless they're locally or remotely stored.
2) The size shouldn't be the way to verify whether an image has some data or not.

https://git.openstack.org/cgit/openstack/glance/tree/glance/api/v1/images.py#n455

This is happening in the API v1, but it doesn't seem to be true for v2.

** Affects: glance
     Importance: High
         Status: New

** Changed in: glance
   Importance: Undecided => High

** Description changed:

  Glance images are not being fetched by glance's API v1 when the size is
  0. There are 2 things wrong with this behaviour:
  
  1) Active images should always be ready to be downloaded, regardless they're locally or remotely stored.
  2) The size shouldn't be the way to verify whether an image has some data or not.
  
- 431             if image_meta.get('size') == 0:
- 432  ->             image_iterator = iter([])
- 433             else:
- 434                 image_iterator, size = self._get_from_store(req.context,
- 435                                                             image_meta['location'])
- 436                 image_iterator = utils.cooperative_iter(image_iterator)
- 437                 image_meta['size'] = size or image_meta['size']
+ https://git.openstack.org/cgit/openstack/glance/tree/glance/api/v1/images.py#n455
  
  This is happening in the API v1, but it doesn't seem to be true for v2.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1257273

Title:
  Glance download fails when size is 0

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  Glance images are not being fetched by glance's API v1 when the size
  is 0. There are 2 things wrong with this behaviour:

  1) Active images should always be ready to be downloaded, regardless they're locally or remotely stored.
  2) The size shouldn't be the way to verify whether an image has some data or not.

  https://git.openstack.org/cgit/openstack/glance/tree/glance/api/v1/images.py#n455

  This is happening in the API v1, but it doesn't seem to be true for
  v2.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1257273/+subscriptions


Follow ups

References