yahoo-eng-team team mailing list archive

[Lance Bragstad <ldbragst@xxxxxxxxxx>]

Public bug reported:

Some things need cleanup in the ML2Manager.

1.) In the current ML2 Manager, we are using sys.exit(1) if the
network_type isn't found in self.drivers:

https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L70

Here we should probably throw an exception. When running unit test, if
we hit this condition the unit tests will exit as well.

2.) We should also be mindful of using the reserved keyword 'type' and
rename type in this case to something else:

https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L49

** Affects: neutron
     Importance: Undecided
         Status: Confirmed


** Tags: ml2

** Description changed:

- In the current ML2 Manager, we are using sys.exit(1) if the network_type
- isn't found in self.drivers:
+ Some things need cleanup in the ML2Manager.
+ 
+ 1.) In the current ML2 Manager, we are using sys.exit(1) if the
+ network_type isn't found in self.drivers:
  
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L70
  
  Here we should probably throw an exception. When running unit test, if
  we hit this condition the unit tests will exit as well.
  
- We should also be mindful of using the reserved keyword 'type' and
+ 2.) We should also be mindful of using the reserved keyword 'type' and
  rename type in this case to something else:
  
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L49

** Tags added: ml2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1259646

Title:
  Clean up ML2 Manager

Status in OpenStack Neutron (virtual network service):
  Confirmed

Bug description:
  Some things need cleanup in the ML2Manager.

  1.) In the current ML2 Manager, we are using sys.exit(1) if the
  network_type isn't found in self.drivers:

  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L70

  Here we should probably throw an exception. When running unit test, if
  we hit this condition the unit tests will exit as well.

  2.) We should also be mindful of using the reserved keyword 'type' and
  rename type in this case to something else:

  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py#L49

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1259646/+subscriptions