← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1262057] [NEW] XML middleware will try to convert everything even if it's not json

 

Public bug reported:

There are certain routes like /v2.0/certificates/ca that return PEM
files that do not return the standard choice of JSON or XML data. If you
request these routes with XML in the Accept field (like if you hit it
with a browser) then the XML middleware will kick in and assume that,
like other requests, it needs to load it as json then convert it to xml.

This is obviously wrong. We should only be doing XML processing if we
understand the content we are trying to convert, and it is better to
return something that is not on the Accept list than return an error (in
JSON no less).

** Affects: keystone
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1262057

Title:
  XML middleware will try to convert everything even if it's not json

Status in OpenStack Identity (Keystone):
  New

Bug description:
  There are certain routes like /v2.0/certificates/ca that return PEM
  files that do not return the standard choice of JSON or XML data. If
  you request these routes with XML in the Accept field (like if you hit
  it with a browser) then the XML middleware will kick in and assume
  that, like other requests, it needs to load it as json then convert it
  to xml.

  This is obviously wrong. We should only be doing XML processing if we
  understand the content we are trying to convert, and it is better to
  return something that is not on the Accept list than return an error
  (in JSON no less).

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1262057/+subscriptions


Follow ups

References