yahoo-eng-team team mailing list archive

[Dirk Mueller <1262723@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Nova uses libvirt.baselineCPU when support for it is available in the
installed libvirt version. the implementation of baselineCPU is:

    def baselineCPU(self, xmlCPUs, flags=0):
        """Computes the most feature-rich CPU which is compatible with all given host CPUs. """
        ret = libvirtmod.virConnectBaselineCPU(self._o, xmlCPUs, flags)
        if ret is None: raise libvirtError ('virConnectBaselineCPU() failed', conn=self)
        return ret


which means, it raises libvirt.libvirtError() on failures. Unfortunatly there is a bug in the python wrapper as it checks for ret being None, while the ret value on failure is actually int(-1). So we need to adjust and make sure that we handle -1 as well.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1262723

Title:
  libvirt.baselineCPU error handling in Nova

Status in OpenStack Compute (Nova):
  New

Bug description:
  Nova uses libvirt.baselineCPU when support for it is available in the
  installed libvirt version. the implementation of baselineCPU is:

      def baselineCPU(self, xmlCPUs, flags=0):
          """Computes the most feature-rich CPU which is compatible with all given host CPUs. """
          ret = libvirtmod.virConnectBaselineCPU(self._o, xmlCPUs, flags)
          if ret is None: raise libvirtError ('virConnectBaselineCPU() failed', conn=self)
          return ret

  
  which means, it raises libvirt.libvirtError() on failures. Unfortunatly there is a bug in the python wrapper as it checks for ret being None, while the ret value on failure is actually int(-1). So we need to adjust and make sure that we handle -1 as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1262723/+subscriptions