yahoo-eng-team team mailing list archive

[Jay Lau <jay.lau.513@xxxxxxxxx>]

Public bug reported:

>From the comments of update_service_capabilities, it is said that once
publish_service_capabilities was removed, then we can begin the process
of  its removal.

Now publish_service_capabilities has been removed, so we can remove
update_service_capabilities now as no one is calling it

def update_service_capabilities(self, context, service_name,
                                    host, capabilities):
        """Process a capability update from a service node."""
        #NOTE(jogo) This is deprecated, but is used by the deprecated
        # publish_service_capabilities call. So this can begin its removal
        # process once publish_service_capabilities is removed.
        if not isinstance(capabilities, list):
            capabilities = [capabilities]
        for capability in capabilities:
            if capability is None:
                capability = {}
            self.driver.update_service_capabilities(service_name, host,
                                                    capability)

** Affects: nova
     Importance: Undecided
     Assignee: Jay Lau (jay-lau-513)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Jay Lau (jay-lau-513)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1263569

Title:
  Remove update_service_capabilities from nova

Status in OpenStack Compute (Nova):
  New

Bug description:
  From the comments of update_service_capabilities, it is said that once
  publish_service_capabilities was removed, then we can begin the
  process of  its removal.

  Now publish_service_capabilities has been removed, so we can remove
  update_service_capabilities now as no one is calling it

  def update_service_capabilities(self, context, service_name,
                                      host, capabilities):
          """Process a capability update from a service node."""
          #NOTE(jogo) This is deprecated, but is used by the deprecated
          # publish_service_capabilities call. So this can begin its removal
          # process once publish_service_capabilities is removed.
          if not isinstance(capabilities, list):
              capabilities = [capabilities]
          for capability in capabilities:
              if capability is None:
                  capability = {}
              self.driver.update_service_capabilities(service_name, host,
                                                      capability)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1263569/+subscriptions