← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1268480] Re: assertTrue(isinstance()) in tests should be replace with assertIsInstance()

 

** Also affects: cinder
   Importance: Undecided
       Status: New

** Changed in: cinder
     Assignee: (unassigned) => Liusheng (liusheng)

** Also affects: python-ceilometerclient
   Importance: Undecided
       Status: New

** Changed in: python-ceilometerclient
     Assignee: (unassigned) => Liusheng (liusheng)

** Also affects: python-cinderclient
   Importance: Undecided
       Status: New

** Changed in: python-cinderclient
     Assignee: (unassigned) => Liusheng (liusheng)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in OpenStack Telemetry (Ceilometer):
  New
Status in Cinder:
  New
Status in OpenStack Image Registry and Delivery Service (Glance):
  In Progress
Status in OpenStack Identity (Keystone):
  In Progress
Status in OpenStack Neutron (virtual network service):
  New
Status in OpenStack Compute (Nova):
  New
Status in Python client library for Ceilometer:
  New
Status in Python client library for Cinder:
  New
Status in Python client library for Nova:
  In Progress

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1268480/+subscriptions


References