← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1268480] [NEW] assertTrue(isinstance()) in tests should be replace with assertIsInstance()

 

Public bug reported:

some of tests use different method of assertTrue(isinstance(A, B)) or
assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
B) provided by testtools

** Affects: ceilometer
     Importance: Undecided
     Assignee: lizheming (lizheming-li)
         Status: New

** Affects: glance
     Importance: Undecided
     Assignee: wanghong (w-wanghong)
         Status: New

** Affects: keystone
     Importance: Undecided
     Assignee: wanghong (w-wanghong)
         Status: New

** Affects: neutron
     Importance: Undecided
     Assignee: lizheming (lizheming-li)
         Status: New

** Affects: nova
     Importance: Undecided
     Assignee: lizheming (lizheming-li)
         Status: New

** Affects: python-novaclient
     Importance: Undecided
     Assignee: lizheming (lizheming-li)
         Status: New

** Also affects: glance
   Importance: Undecided
       Status: New

** Also affects: keystone
   Importance: Undecided
       Status: New

** Also affects: neutron
   Importance: Undecided
       Status: New

** Also affects: cinder
   Importance: Undecided
       Status: New

** Also affects: ceilometer
   Importance: Undecided
       Status: New

** Changed in: nova
     Assignee: (unassigned) => lizheming (lizheming-li)

** Changed in: cinder
     Assignee: (unassigned) => lizheming (lizheming-li)

** Changed in: neutron
     Assignee: (unassigned) => lizheming (lizheming-li)

** Changed in: ceilometer
     Assignee: (unassigned) => lizheming (lizheming-li)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in OpenStack Telemetry (Ceilometer):
  New
Status in OpenStack Image Registry and Delivery Service (Glance):
  New
Status in OpenStack Identity (Keystone):
  New
Status in OpenStack Neutron (virtual network service):
  New
Status in OpenStack Compute (Nova):
  New
Status in Python client library for Nova:
  New

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1268480/+subscriptions


Follow ups

References