yahoo-eng-team team mailing list archive

[Shantanu Tushar <shaan7in@xxxxxxxxx>]

Public bug reported:

In nova/service.py, the configuration defaults for the *_listen,
*_listen_port  are specified both in Opt and while using getattr to read
the option value-

self.host = getattr(CONF, '%s_listen' % name, "0.0.0.0")
self.port = getattr(CONF, '%s_listen_port' % name, 0)
self.workers = getattr(CONF, '%s_workers' % name, None)

This is duplication of the default values and might produce inconsistent
results when someone modified only one of these.

Another problem in the same code above is that reading an erroneous
config value (lets say foo_workers) will not fail and will simply give a
default. This makes it easy for a typo in config to pass silently.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1270196

Title:
  Nova services use configuration default values inconsistently

Status in OpenStack Compute (Nova):
  New

Bug description:
  In nova/service.py, the configuration defaults for the *_listen,
  *_listen_port  are specified both in Opt and while using getattr to
  read the option value-

  self.host = getattr(CONF, '%s_listen' % name, "0.0.0.0")
  self.port = getattr(CONF, '%s_listen_port' % name, 0)
  self.workers = getattr(CONF, '%s_workers' % name, None)

  This is duplication of the default values and might produce
  inconsistent results when someone modified only one of these.

  Another problem in the same code above is that reading an erroneous
  config value (lets say foo_workers) will not fail and will simply give
  a default. This makes it easy for a typo in config to pass silently.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1270196/+subscriptions