yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1252996

Title:
  [horizon] [fwaas] "Remove Rule" from a policy should be available only
  when rules are associated with the policy

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Description
  ===========
  Currently, when a firewall policy has no associated rules, the "Firewalls"->"Firewall Policies"->"More" button of a policy->"Remove Rule" option is available (and not in red font), when clicking on it, it's possible to click on the "Save Changes" button of the opened "Remove Rule from Policy" dialog and get the following error:

  Error: Failed to remove rule from policy policy_test:
  404-{u'NeutronError': {u'message': u'Firewall Rule .json could not be
  found.', u'type': u'FirewallRuleNotFound', u'detail': u''}}

  I'd expect:
    i. The "Remove Rule" should appear in red font
   ii. The "Save Changes" in the "Remove Rule from Policy" dialog should be grayed-out
  iii. This operation should not lead to error, but to warning
   iv. The error message is wrong anyway, it should be something like "No sssociated Firewall Rule could be found" instead of "Firewall Rule .json could not be found"

  From the log file
  =================
  2013-11-20 09:39:48.467 26712 ERROR neutron.api.v2.resource [-] show failed
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource Traceback (most recent call last):
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource   File "/usr/lib/python2.6/site-packages/neutron/api/v2/resource.py", line 84, in resource
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource     result = method(request=request, **args)
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource   File "/usr/lib/python2.6/site-packages/neutron/api/v2/base.py", line 290, in show
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource     parent_id=parent_id),
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource   File "/usr/lib/python2.6/site-packages/neutron/api/v2/base.py", line 258, in _item
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource     obj = obj_getter(request.context, id, **kwargs)
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource   File "/usr/lib/python2.6/site-packages/neutron/db/firewall/firewall_db.py", line 403, in get_firewall_rule
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource     fwr = self._get_firewall_rule(context, id)
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource   File "/usr/lib/python2.6/site-packages/neutron/db/firewall/firewall_db.py", line 111, in _get_firewall_rule
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource     raise firewall.FirewallRuleNotFound(firewall_rule_id=id)
  2013-11-20 09:39:48.467 26712 TRACE neutron.api.v2.resource FirewallRuleNotFound: Firewall Rule .json could not be found.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1252996/+subscriptions