yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: horizon
       Status: Fix Committed => Fix Released

** Changed in: horizon
    Milestone: None => icehouse-2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1251546

Title:
  Useless asserts in __init__ files

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In many __init__.py files in Horizon there is code that looks like
  this:

  from horizon.base import Dashboard  # noqa
  from horizon.base import Panel  # noqa
  from horizon.base import PanelGroup  # noqa

  # silence flake8 about unused imports here:
  assert Dashboard
  assert Panel
  assert PanelGroup

  This breaks when the imports are optional, and would be much better
  done by defining __all__ with the relevant names.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1251546/+subscriptions