yahoo-eng-team team mailing list archive

[Ilya Pekelny <pekelny@xxxxxxxxx>]

Public bug reported:

If we look attentively to a `find_migrate_repo` usage we will see:
    $ grep -r "find_migrate_repo" keystone

    keystone/common/sql/migration.py:        repo_path = find_migrate_repo()
    keystone/common/sql/migration.py:        repo_path = find_migrate_repo()
    keystone/common/sql/migration.py:        repo_path = find_migrate_repo()

The function never been used with an argument. What does it mean? This
mean that the only line is needed in this function
https://github.com/openstack/keystone/blob/master/keystone/common/sql/migration.py#L87.
And at this point the function is redundant in the current state. Must
be refactored.

** Affects: keystone
     Importance: Undecided
     Assignee: Ilya Pekelny (i159)
         Status: New

** Changed in: keystone
     Assignee: (unassigned) => Ilya Pekelny (i159)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1273336

Title:
  common.sql.migration.find_migrate_repo never used with an argument.

Status in OpenStack Identity (Keystone):
  New

Bug description:
  If we look attentively to a `find_migrate_repo` usage we will see:
      $ grep -r "find_migrate_repo" keystone

      keystone/common/sql/migration.py:        repo_path = find_migrate_repo()
      keystone/common/sql/migration.py:        repo_path = find_migrate_repo()
      keystone/common/sql/migration.py:        repo_path = find_migrate_repo()

  The function never been used with an argument. What does it mean? This
  mean that the only line is needed in this function
  https://github.com/openstack/keystone/blob/master/keystone/common/sql/migration.py#L87.
  And at this point the function is redundant in the current state. Must
  be refactored.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1273336/+subscriptions