← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1273451] [NEW] improper use of mock with stevedore in tests

 

Public bug reported:

The tests in nova/tests/test_hook.py are mocking a private part of the
stevedore API (_load_plugins) instead of using
ExtensionManager.make_test_instance() to create a test version of an
ExtensionManager and passing that somewhere instead.

See https://review.openstack.org/#/c/69475/1 as a first-pass work-
around.

** Affects: nova
     Importance: Undecided
         Status: New

** Description changed:

  The tests in nova/tests/test_hook.py are mocking a private part of the
  stevedore API (_load_plugins) instead of using
  ExtensionManager.make_test_instance() to create a test version of an
  ExtensionManager and passing that somewhere instead.
+ 
+ See https://review.openstack.org/#/c/69475/1 as a first-pass work-
+ around.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1273451

Title:
  improper use of mock with stevedore in tests

Status in OpenStack Compute (Nova):
  New

Bug description:
  The tests in nova/tests/test_hook.py are mocking a private part of the
  stevedore API (_load_plugins) instead of using
  ExtensionManager.make_test_instance() to create a test version of an
  ExtensionManager and passing that somewhere instead.

  See https://review.openstack.org/#/c/69475/1 as a first-pass work-
  around.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1273451/+subscriptions


Follow ups

References