yahoo-eng-team team mailing list archive

[Dan Smith <dms@xxxxxxxxxxxxx>]

Public bug reported:

Several virt drivers are using non-standard driver-specific image
metadata properties. This creates an API contract between the external
user and the driver implementation. These non-standard ones should be
marked as deprecated in some way, enforced in v3, etc. We need a global
whitelist of keys and values that are allowed so that we can make sure
others don't leak in.

Examples:

nova/virt/vmwareapi/vmops.py:            os_type = image_properties.get("vmware_ostype", "otherGuest")
nova/virt/vmwareapi/vmops.py:            adapter_type = image_properties.get("vmware_adaptertype",
nova/virt/vmwareapi/vmops.py:            disk_type = image_properties.get("vmware_disktype",
nova/virt/vmwareapi/vmops.py:            vif_model = image_properties.get("hw_vif_model", "VirtualE1000")

nova/virt/xenapi/vm_utils.py:    device_id =
image_properties.get('xenapi_device_id')

I think it's important to try to get this fixed (or as close as
possible) before the icehouse release.

** Affects: nova
     Importance: Medium
         Status: Confirmed

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1275875

Title:
  Virt drivers should use standard image properties

Status in OpenStack Compute (Nova):
  Confirmed

Bug description:
  Several virt drivers are using non-standard driver-specific image
  metadata properties. This creates an API contract between the external
  user and the driver implementation. These non-standard ones should be
  marked as deprecated in some way, enforced in v3, etc. We need a
  global whitelist of keys and values that are allowed so that we can
  make sure others don't leak in.

  Examples:

  nova/virt/vmwareapi/vmops.py:            os_type = image_properties.get("vmware_ostype", "otherGuest")
  nova/virt/vmwareapi/vmops.py:            adapter_type = image_properties.get("vmware_adaptertype",
  nova/virt/vmwareapi/vmops.py:            disk_type = image_properties.get("vmware_disktype",
  nova/virt/vmwareapi/vmops.py:            vif_model = image_properties.get("hw_vif_model", "VirtualE1000")

  nova/virt/xenapi/vm_utils.py:    device_id =
  image_properties.get('xenapi_device_id')

  I think it's important to try to get this fixed (or as close as
  possible) before the icehouse release.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1275875/+subscriptions