← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1276203] [NEW] Period task interval config values need to be consistent

 

Public bug reported:

Currently we have a mix of “==0” and “<=0” being used inside periodic
tasks to decide to skip the task altogether.   We also have the
“spacing=” option in the periodic_task decorator to determine how often
to call the task, but in this case:  ==0 means “call at default
interval” and <0 means “never call”.     It would be nice to make these
consistent so that all tasks can use the spacing option rather than keep
their own check on when (and if)  they  need to run.

However in order to do this cleanly and not break anyone that is currently using “0 “ to mean “don’t run” we need to:
-	Change the default values that are currently 0 to -1
-	Log a deprecation warning for the use “*_interval=0”

And then leave this in place until after Juno before making the change

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1276203

Title:
  Period task interval config values need to be consistent

Status in OpenStack Compute (Nova):
  New

Bug description:
  Currently we have a mix of “==0” and “<=0” being used inside periodic
  tasks to decide to skip the task altogether.   We also have the
  “spacing=” option in the periodic_task decorator to determine how
  often to call the task, but in this case:  ==0 means “call at default
  interval” and <0 means “never call”.     It would be nice to make
  these consistent so that all tasks can use the spacing option rather
  than keep their own check on when (and if)  they  need to run.

  However in order to do this cleanly and not break anyone that is currently using “0 “ to mean “don’t run” we need to:
  -	Change the default values that are currently 0 to -1
  -	Log a deprecation warning for the use “*_interval=0”

  And then leave this in place until after Juno before making the change

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1276203/+subscriptions


Follow ups

References