yahoo-eng-team team mailing list archive

[Hans Lindgren <1284345@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Network manager methods add_fixed_ip_to_instance() and
remove_fixed_ip_from_instance() both return with updated nw_info models.
The corresponding network API methods however returns nothing, which has
the following effect:

Both API methods have the @refresh_cache decorator that tries to update
instance info cache from the decorated method's return value. In absence
of a return value, it will make a new rpc call to to get the missing
nw_info model. By changing the two API methods so that they return the
models that they in fact already get, these extra calls can be avoided
altogether.

In addition, having the API methods return updated nw_info models make
it possible to further improve as in compute manager, calls to these
methods are immediately followed by calls to get updated nw_info.

** Affects: nova
     Importance: Medium
     Assignee: Hans Lindgren (hanlind)
         Status: New


** Tags: network

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1284345

Title:
  Some network API methods unnecessarily trigger multiple
  get_instance_nw_info() calls

Status in OpenStack Compute (Nova):
  New

Bug description:
  Network manager methods add_fixed_ip_to_instance() and
  remove_fixed_ip_from_instance() both return with updated nw_info
  models. The corresponding network API methods however returns nothing,
  which has the following effect:

  Both API methods have the @refresh_cache decorator that tries to
  update instance info cache from the decorated method's return value.
  In absence of a return value, it will make a new rpc call to to get
  the missing nw_info model. By changing the two API methods so that
  they return the models that they in fact already get, these extra
  calls can be avoided altogether.

  In addition, having the API methods return updated nw_info models make
  it possible to further improve as in compute manager, calls to these
  methods are immediately followed by calls to get updated nw_info.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1284345/+subscriptions