yahoo-eng-team team mailing list archive

[Johannes Erdfelt <1286187@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Both execute_get_output() and execute() don't wait until the process is
finished running.

execute_get_output() probably hasn't caused a problem since it at least
does one read and the commands it runs likely would finish (but this
isn't guaranteed).

execute() sets up a PIPE for the process stdout, but doesn't do any
reads before returning to the caller. This could make the code execute
multiple processes in parallel leading to a race condition that could
cause commands to execute in the opposite order that is intended. It
could potentially also cause the process to block on writes to the PIPE
that isn't being read leading it to never finish executing.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1286187

Title:
  plugins/xenserver/networking/etc/xensource/scripts/novalib.py uses
  subprocess incorrectly

Status in OpenStack Compute (Nova):
  New

Bug description:
  Both execute_get_output() and execute() don't wait until the process
  is finished running.

  execute_get_output() probably hasn't caused a problem since it at
  least does one read and the commands it runs likely would finish (but
  this isn't guaranteed).

  execute() sets up a PIPE for the process stdout, but doesn't do any
  reads before returning to the caller. This could make the code execute
  multiple processes in parallel leading to a race condition that could
  cause commands to execute in the opposite order that is intended. It
  could potentially also cause the process to block on writes to the
  PIPE that isn't being read leading it to never finish executing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1286187/+subscriptions