← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1268480] Re: assertTrue(isinstance()) in tests should be replace with assertIsInstance()

 

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in OpenStack Telemetry (Ceilometer):
  Fix Committed
Status in Cinder:
  Opinion
Status in OpenStack Image Registry and Delivery Service (Glance):
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Committed
Status in Ironic (Bare Metal Provisioning):
  Fix Released
Status in OpenStack Identity (Keystone):
  Fix Committed
Status in OpenStack Neutron (virtual network service):
  Invalid
Status in OpenStack Compute (Nova):
  Fix Released
Status in Python client library for Ceilometer:
  Fix Committed
Status in Python client library for Cinder:
  In Progress
Status in Python client library for Keystone:
  Fix Released
Status in Python client library for Nova:
  Fix Released

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1268480/+subscriptions


References