← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1290583] [NEW] Unhandled UnboundLocalError in IPAssociationWorkflow

 

Public bug reported:

If an error is raised in the AssociateIPAction we assume that a redirect
will be raised. However, certain exception classes will not result in a
redirect when handled by the standard Horizon exception handler.

The two problem spots are in AssociateIPAction.populate_ip_id_choices
(https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/access_and_security/floating_ips/workflows.py#L68)
and AssociateIPAction. populate_instance_id_choices
(https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/access_and_security/floating_ips/workflows.py#L84)

If the error handler doesn't raise a redirect, control will be returned
to the statement after the 'except' block but some of the necessary
variables may be unbound.

** Affects: horizon
     Importance: Undecided
     Assignee: Brian DeHamer (brian-dehamer)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Brian DeHamer (brian-dehamer)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1290583

Title:
  Unhandled UnboundLocalError in IPAssociationWorkflow

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  If an error is raised in the AssociateIPAction we assume that a
  redirect will be raised. However, certain exception classes will not
  result in a redirect when handled by the standard Horizon exception
  handler.

  The two problem spots are in AssociateIPAction.populate_ip_id_choices
  (https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/access_and_security/floating_ips/workflows.py#L68)
  and AssociateIPAction. populate_instance_id_choices
  (https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/access_and_security/floating_ips/workflows.py#L84)

  If the error handler doesn't raise a redirect, control will be
  returned to the statement after the 'except' block but some of the
  necessary variables may be unbound.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1290583/+subscriptions


Follow ups

References