yahoo-eng-team team mailing list archive

[Johannes Erdfelt <1290903@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The code currently does:

        vdi_uuids = []
         for vbd_uuid in rescue_vm["VBDs"]:
            vdi_uuids.append(xenapi_fake.get_record('VBD', vbd_uuid)["VDI"])
        self.assertNotIn("swap", vdi_uuids)

vdi_uuids is a list of uuid references. "swap" will never match a uuid,
so that test will always be true, even if the code is broken.

** Affects: nova
     Importance: Undecided
     Assignee: Johannes Erdfelt (johannes.erdfelt)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Johannes Erdfelt (johannes.erdfelt)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1290903

Title:
  xenapi: test_rescue incorrectly verifies original swap wasn't attached

Status in OpenStack Compute (Nova):
  New

Bug description:
  The code currently does:

          vdi_uuids = []
           for vbd_uuid in rescue_vm["VBDs"]:
              vdi_uuids.append(xenapi_fake.get_record('VBD', vbd_uuid)["VDI"])
          self.assertNotIn("swap", vdi_uuids)

  vdi_uuids is a list of uuid references. "swap" will never match a
  uuid, so that test will always be true, even if the code is broken.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1290903/+subscriptions