yahoo-eng-team team mailing list archive

[Jay Pipes <1292997@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

For some reason, nova.volume.cinder.API derives from nova.db.base.Base,
which looks like this (in its entirety):

class Base(object):
    """DB driver is injected in the init method."""

    def __init__(self, db_driver=None):
        super(Base, self).__init__()
        if not db_driver:
            db_driver = CONF.db_driver
        self.db = importutils.import_module(db_driver)  # pylint: disable=C0103

I checked and nova.volume.cinder.API makes no reference at all to
self.db, therefore unless I am mistaken, there's no reason for this
inheritance.

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: cinder low-hanging-fruit

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1292997

Title:
  nova.volume.cinder.API incorrectly derives from nova.db.base.Base

Status in OpenStack Compute (Nova):
  New

Bug description:
  For some reason, nova.volume.cinder.API derives from
  nova.db.base.Base, which looks like this (in its entirety):

  class Base(object):
      """DB driver is injected in the init method."""

      def __init__(self, db_driver=None):
          super(Base, self).__init__()
          if not db_driver:
              db_driver = CONF.db_driver
          self.db = importutils.import_module(db_driver)  # pylint: disable=C0103

  I checked and nova.volume.cinder.API makes no reference at all to
  self.db, therefore unless I am mistaken, there's no reason for this
  inheritance.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1292997/+subscriptions