yahoo-eng-team team mailing list archive

[Doug Fish <drfish@xxxxxxxxxx>]

Public bug reported:

The current fix to make mox not needed in a non dev environment includes
a lazy-loading pattern in horizon/test/jasmine/jasmine.py.  This is
undesirable because we'd like to keep the imports at the top of the
file.

Refactor to avoid this pattern.  Look at change set 6 from
https://review.openstack.org/#/c/79378/ as a potential way to do this.
Note that selenium.py in horizon/test/tests should be renamed to
selenium_helpers.py because inside a selenium.py file you can't import a
module named selenium.  PYTHONPATH will load the file first instead of
the one in dist-package.

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1298473

Title:
  mox fix with better placed import

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  The current fix to make mox not needed in a non dev environment
  includes a lazy-loading pattern in horizon/test/jasmine/jasmine.py.
  This is undesirable because we'd like to keep the imports at the top
  of the file.

  Refactor to avoid this pattern.  Look at change set 6 from
  https://review.openstack.org/#/c/79378/ as a potential way to do this.
  Note that selenium.py in horizon/test/tests should be renamed to
  selenium_helpers.py because inside a selenium.py file you can't import
  a module named selenium.  PYTHONPATH will load the file first instead
  of the one in dist-package.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1298473/+subscriptions