yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1240572

Title:
  ovs_lib.OVSBridge flow managment methods poor design

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  Unlike 'set_db_attribute()' and 'clear_db_attribute' methods which
  don't restrict our choice of desired attributes, flow managment
  methods such as 'add_flow', 'mod_flow' and 'delete_flows' internally
  make use of '_build_flow_expr_arr()' method, which validates and
  limits flow parameters. Beside from obvious inconsistency I see the
  following problems:

  - If we misspell flow parameter it just will be ignored, and instead of exception (this is what we would expect) wrong flow will be defined.
  - To add more flow options we have to keep hardcoding them in '_build_flow_expr_arr()'

  My proposition is to use similar to 'set_db_attribute()' method
  approach - don't restrict which options we can use, just pack them and
  execute the command.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1240572/+subscriptions