yahoo-eng-team team mailing list archive

[Salvatore Orlando <1304723@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

In the create_port method for the NSX plugin, successful creation in NSX is logged even before the DB transaction is committed.
This should be fixed with a simple patch.

diff --git a/neutron/plugins/vmware/plugins/base.py b/neutron/plugins/vmware/plugins/base.py
index fc39bec..9f9f7ac 100644
--- a/neutron/plugins/vmware/plugins/base.py
+++ b/neutron/plugins/vmware/plugins/base.py
@@ -1169,10 +1169,6 @@ class NsxPluginV2(addr_pair_db.AllowedAddressPairsMixin,
                 self._create_mac_learning_state(context, port_data)
             elif mac_ext.MAC_LEARNING in port_data:
                 port_data.pop(mac_ext.MAC_LEARNING)
-
-            LOG.debug(_("create_port completed on NSX for tenant "
-                        "%(tenant_id)s: (%(id)s)"), port_data)
-
             self._process_portbindings_create_and_update(context,
                                                          port['port'],
                                                          port_data)
@@ -1183,6 +1179,8 @@ class NsxPluginV2(addr_pair_db.AllowedAddressPairsMixin,
                 port_data['device_owner'],
                 self._port_drivers['create']['default'])
             port_create_func(context, port_data)
+            LOG.debug(_("port created on NSX backend for tenant "
+                        "%(tenant_id)s: (%(id)s)"), port_data)
         except n_exc.NotFound:
             LOG.warning(_("Logical switch for network %s was not "
                           "found in NSX."), port_data['network_id'])

** Affects: neutron
     Importance: Low
     Assignee: Salvatore Orlando (salvatore-orlando)
         Status: New


** Tags: vmware

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1304723

Title:
  Misplaced log statement in NSX plugin

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  In the create_port method for the NSX plugin, successful creation in NSX is logged even before the DB transaction is committed.
  This should be fixed with a simple patch.

  diff --git a/neutron/plugins/vmware/plugins/base.py b/neutron/plugins/vmware/plugins/base.py
  index fc39bec..9f9f7ac 100644
  --- a/neutron/plugins/vmware/plugins/base.py
  +++ b/neutron/plugins/vmware/plugins/base.py
  @@ -1169,10 +1169,6 @@ class NsxPluginV2(addr_pair_db.AllowedAddressPairsMixin,
                   self._create_mac_learning_state(context, port_data)
               elif mac_ext.MAC_LEARNING in port_data:
                   port_data.pop(mac_ext.MAC_LEARNING)
  -
  -            LOG.debug(_("create_port completed on NSX for tenant "
  -                        "%(tenant_id)s: (%(id)s)"), port_data)
  -
               self._process_portbindings_create_and_update(context,
                                                            port['port'],
                                                            port_data)
  @@ -1183,6 +1179,8 @@ class NsxPluginV2(addr_pair_db.AllowedAddressPairsMixin,
                   port_data['device_owner'],
                   self._port_drivers['create']['default'])
               port_create_func(context, port_data)
  +            LOG.debug(_("port created on NSX backend for tenant "
  +                        "%(tenant_id)s: (%(id)s)"), port_data)
           except n_exc.NotFound:
               LOG.warning(_("Logical switch for network %s was not "
                             "found in NSX."), port_data['network_id'])

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1304723/+subscriptions