← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1307025] [NEW] Patch in cisco unit test not being correctly cleared by stopall

 

Public bug reported:

A recent patch removed the explicit patch stops from most of the unit
tests to let the default mock.patch.stopall handle the cleanup[1].
However, there appears to be cases where stopall loses the reference to
a patch and doesn't stop it correctly. In this particular case, the
nexus test patch to sys.modules is not being stopped correctly so it's
causing unit test failures in the gate[2].


1. https://github.com/openstack/neutron/commit/6546ba570367aba7209ec36544ec4cf742e0bd63
2. http://logs.openstack.org/10/86810/5/check/gate-neutron-python27/89dfa5c/testr_results.html.gz

** Affects: neutron
     Importance: Undecided
     Assignee: Kevin Benton (kevinbenton)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Kevin Benton (kevinbenton)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1307025

Title:
  Patch in cisco unit test not being correctly cleared by stopall

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  A recent patch removed the explicit patch stops from most of the unit
  tests to let the default mock.patch.stopall handle the cleanup[1].
  However, there appears to be cases where stopall loses the reference
  to a patch and doesn't stop it correctly. In this particular case, the
  nexus test patch to sys.modules is not being stopped correctly so it's
  causing unit test failures in the gate[2].

  
  1. https://github.com/openstack/neutron/commit/6546ba570367aba7209ec36544ec4cf742e0bd63
  2. http://logs.openstack.org/10/86810/5/check/gate-neutron-python27/89dfa5c/testr_results.html.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1307025/+subscriptions


Follow ups

References