yahoo-eng-team team mailing list archive

[Doug Hellmann <doug.hellmann@xxxxxxxxxxxxx>]

Public bug reported:

As discussed on IRC:

[Mon 03:49:43 PM]  <dhellmann>	 I'm trying to package keystone from master, and run the tests. In order to run the tests in the virtualenv I'm creating, I change tox.ini to set a couple of variables differently: http://paste.openstack.org/show/76559/
[Mon 03:49:50 PM]  <dhellmann>	 morganfainberg: yeah
[Mon 03:50:02 PM]  <dhellmann>	 it seems that setting usedevelop=False breaks that function
[Mon 03:50:14 PM]  <morganfainberg>	 oh oh i see how it could.
[Mon 03:50:15 PM]  <morganfainberg>	 doh*
[Mon 03:50:41 PM]  <dhellmann>	 because it finds a path for the module with a full path, and the / becomes a . and then import complains that '.home.whatever.some.long.path' has an empty module name
[Mon 03:50:45 PM]  <dhellmann>	 at the front there
[Mon 03:51:33 PM]  <dhellmann>	 morganfainberg: so we could fix it a couple of ways, either by doing more smart work with the paths, or by converting those modules to be loaded with stevedore
[Mon 03:51:44 PM]  <dhellmann>	 morganfainberg: before I submit a patch, I thought I'd see which you all would prefer
[Mon 03:51:47 PM]  <morganfainberg>	 dhellmann, the latter would be better
[Mon 03:52:15 PM]  <morganfainberg>	 dhellmann, i would rather use stevedore for all of our backends eventually, it makes sense that the tests should be the same
[Mon 03:52:16 PM]  <dhellmann>	 ok, I concur, but didn't know if there was some reason it was done this way to begin with
[Mon 03:52:38 PM]  <morganfainberg>	 dhellmann, we haven't converted stuff to stevedore yet, afaict that is the reason

** Affects: keystone
     Importance: Undecided
     Assignee: Doug Hellmann (doug-hellmann)
         Status: Triaged

** Changed in: keystone
     Assignee: (unassigned) => Doug Hellmann (doug-hellmann)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1310768

Title:
  keystone tests fail unless tox is configured "just so"

Status in OpenStack Identity (Keystone):
  Triaged

Bug description:
  As discussed on IRC:

  [Mon 03:49:43 PM]  <dhellmann>	 I'm trying to package keystone from master, and run the tests. In order to run the tests in the virtualenv I'm creating, I change tox.ini to set a couple of variables differently: http://paste.openstack.org/show/76559/
  [Mon 03:49:50 PM]  <dhellmann>	 morganfainberg: yeah
  [Mon 03:50:02 PM]  <dhellmann>	 it seems that setting usedevelop=False breaks that function
  [Mon 03:50:14 PM]  <morganfainberg>	 oh oh i see how it could.
  [Mon 03:50:15 PM]  <morganfainberg>	 doh*
  [Mon 03:50:41 PM]  <dhellmann>	 because it finds a path for the module with a full path, and the / becomes a . and then import complains that '.home.whatever.some.long.path' has an empty module name
  [Mon 03:50:45 PM]  <dhellmann>	 at the front there
  [Mon 03:51:33 PM]  <dhellmann>	 morganfainberg: so we could fix it a couple of ways, either by doing more smart work with the paths, or by converting those modules to be loaded with stevedore
  [Mon 03:51:44 PM]  <dhellmann>	 morganfainberg: before I submit a patch, I thought I'd see which you all would prefer
  [Mon 03:51:47 PM]  <morganfainberg>	 dhellmann, the latter would be better
  [Mon 03:52:15 PM]  <morganfainberg>	 dhellmann, i would rather use stevedore for all of our backends eventually, it makes sense that the tests should be the same
  [Mon 03:52:16 PM]  <dhellmann>	 ok, I concur, but didn't know if there was some reason it was done this way to begin with
  [Mon 03:52:38 PM]  <morganfainberg>	 dhellmann, we haven't converted stuff to stevedore yet, afaict that is the reason

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1310768/+subscriptions