← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1312192] [NEW] On security groups page, attribute error in error handle

 

Public bug reported:

On the  project/access_and_security/security_groups/<detail> page, some
errors inside the
openstack_dashboard/dashboards/project/access_and_security/security_groups/views
DetailView._get_data method are still resulting in a None being
returned.  This causes an error in the DetailView.get_data method as
NoneTypes clearly don't have a .rules attribute.

I'm not sure why the error is sneaking through the exceptions.handle
above, but they most definitely are.  Perhaps Ana Krivokapic's changes
here: https://review.openstack.org/#/c/84109/ may eventually solve this,
but it's unclear.

In the mean time, and potentially correct overall, if a None is
returned, the get_data method should return an empty list instead of
throwing an exception.

** Affects: horizon
     Importance: Undecided
     Assignee: Matthew D. Wood (woodm1979)
         Status: In Progress

** Changed in: horizon
     Assignee: (unassigned) => Matthew D. Wood (woodm1979)

** Changed in: horizon
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1312192

Title:
  On security groups page, attribute error in error handle

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  On the  project/access_and_security/security_groups/<detail> page,
  some errors inside the
  openstack_dashboard/dashboards/project/access_and_security/security_groups/views
  DetailView._get_data method are still resulting in a None being
  returned.  This causes an error in the DetailView.get_data method as
  NoneTypes clearly don't have a .rules attribute.

  I'm not sure why the error is sneaking through the exceptions.handle
  above, but they most definitely are.  Perhaps Ana Krivokapic's changes
  here: https://review.openstack.org/#/c/84109/ may eventually solve
  this, but it's unclear.

  In the mean time, and potentially correct overall, if a None is
  returned, the get_data method should return an empty list instead of
  throwing an exception.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1312192/+subscriptions


Follow ups

References