yahoo-eng-team team mailing list archive

[Liyingjun <liyingjun1988@xxxxxxxxx>]

Public bug reported:

This <elif source_type == 'volume_image_id'> will never be called:
https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#n265
, because <if source_type in ('image_id', 'volume_image_id')>  is called
before the code,
https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#n186

** Affects: horizon
     Importance: Undecided
     Assignee: Liyingjun (liyingjun)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Liyingjun (liyingjun)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1313473

Title:
  Wrong logic in clean method for SetInstanceDetailsAction

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  This <elif source_type == 'volume_image_id'> will never be called:
  https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#n265
  , because <if source_type in ('image_id', 'volume_image_id')>  is
  called before the code,
  https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#n186

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1313473/+subscriptions