yahoo-eng-team team mailing list archive

[Liping Mao <limao@xxxxxxxxx>]

Public bug reported:

This bug is relate with the following bug:
https://bugs.launchpad.net/neutron/+bug/1307344

The fix patch for the bug delete overlap check for fixed ip and allowed
ip address range.

I think that we also need to remove the following code if we do not need to check fixed_ip and allowed address pair overlap:
https://github.com/openstack/neutron/blob/master/neutron/db/allowedaddresspairs_db.py
51 for fixed_ip in port['fixed_ips']:
52 if ((fixed_ip['ip_address'] == address_pair['ip_address'])
53 and (port['mac_address'] ==
54 address_pair['mac_address'])):
55 raise addr_pair.AddressPairMatchesPortFixedIPAndMac()

https://github.com/openstack/neutron/blob/master/neutron/extensions/allowedaddresspairs.py
35class AddressPairMatchesPortFixedIPAndMac(nexception.InvalidInput):
36 message = _("Port's Fixed IP and Mac Address match an address pair entry.")

** Affects: neutron
     Importance: Undecided
     Assignee: Liping Mao (limao)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Liping Mao (limao)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1326007

Title:
  allowed address pairs - overlap check

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  This bug is relate with the following bug:
  https://bugs.launchpad.net/neutron/+bug/1307344

  The fix patch for the bug delete overlap check for fixed ip and
  allowed ip address range.

  I think that we also need to remove the following code if we do not need to check fixed_ip and allowed address pair overlap:
  https://github.com/openstack/neutron/blob/master/neutron/db/allowedaddresspairs_db.py
  51 for fixed_ip in port['fixed_ips']:
  52 if ((fixed_ip['ip_address'] == address_pair['ip_address'])
  53 and (port['mac_address'] ==
  54 address_pair['mac_address'])):
  55 raise addr_pair.AddressPairMatchesPortFixedIPAndMac()

  https://github.com/openstack/neutron/blob/master/neutron/extensions/allowedaddresspairs.py
  35class AddressPairMatchesPortFixedIPAndMac(nexception.InvalidInput):
  36 message = _("Port's Fixed IP and Mac Address match an address pair entry.")

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1326007/+subscriptions