yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

There is debate in the review (which was abandoned).

** Tags added: network

** Changed in: nova
       Status: In Progress => Opinion

** Changed in: nova
     Assignee: Lingxian Kong (kong) => (unassigned)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1205951

Title:
  Detaching interface should be synchronous

Status in OpenStack Compute (Nova):
  Opinion

Bug description:
  the process of attaching a interface to a vm is synchronous, so should
  be detaching interface, otherwise, the exceptions will never be
  captured or reported. See code below:

      def attach_interface(self, ctxt, instance, network_id, port_id,
                           requested_ip):
          instance_p = jsonutils.to_primitive(instance)
          return self.call(ctxt, self.make_msg('attach_interface',
                   instance=instance_p, network_id=network_id,
                   port_id=port_id, requested_ip=requested_ip),
                   topic=_compute_topic(self.topic, ctxt, None, instance),
                   version='2.25')

      def detach_interface(self, ctxt, instance, port_id):
          instance_p = jsonutils.to_primitive(instance)
          self.cast(ctxt, self.make_msg('detach_interface',
                   instance=instance_p, port_id=port_id),
                   topic=_compute_topic(self.topic, ctxt, None, instance),
                   version='2.25')

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1205951/+subscriptions