yahoo-eng-team team mailing list archive

[Paul Michali <1326785@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

As part of bug 1291032 to fix PEP8 H302 violations, some changes made to
UT files in Cisco VPNaaS were not correctly modified (imports that were
for modules already, were changed to import the directory above, instead
of being left alone).

The mistake wasn't detected, because the UT is currently deactivated. To
verify the fix these things are needed:

1) Symlink tests/unit/services/vpn/device_drivers/notest_cisco_csr_rest.py to a name w/o no prefix.
2) manually include httmock library or the source file.
3) Run tox to verify the fix.

Problem affects notest_cisco_csr_rest.py and cisco_csr_mock.py in that
area.

Long term the goal is to resolve the issue with this UTs library usage,
but in the interim, we'd like to keep the file operational until that
time (even if tested manually).

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: cisco vpnaas

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1326785

Title:
  Inactive UT broken on Cisco VPNaaS

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  As part of bug 1291032 to fix PEP8 H302 violations, some changes made
  to UT files in Cisco VPNaaS were not correctly modified (imports that
  were for modules already, were changed to import the directory above,
  instead of being left alone).

  The mistake wasn't detected, because the UT is currently deactivated.
  To verify the fix these things are needed:

  1) Symlink tests/unit/services/vpn/device_drivers/notest_cisco_csr_rest.py to a name w/o no prefix.
  2) manually include httmock library or the source file.
  3) Run tox to verify the fix.

  Problem affects notest_cisco_csr_rest.py and cisco_csr_mock.py in that
  area.

  Long term the goal is to resolve the issue with this UTs library
  usage, but in the interim, we'd like to keep the file operational
  until that time (even if tested manually).

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1326785/+subscriptions