← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1328540] [NEW] Clicks on ajax-modal buttons won't work as expected until portion of code from horizon.modals.js is loaded

 

Public bug reported:

It was reported on Safari browser: if some parts of the page are already
loaded (including some buttons with ajax-modal class), then the click on
the ajax-modal button before the js-handler for .ajax-modal is loaded
will cause non-ajax request, which will probably fail if no special
template for non-ajax request was provided.

One solution is to provide non-ajax template for each .ajax-modal link
for that case - but it seems a bit ugly to me (no fun in showing non-
modal form where a modal one should be).

The solution I've adopted in Murano for that problem is to temporarily
disable all clicks until the page is finally loaded (with a transparent
div covering all the <body> contents, which is hidden once page is
loaded). I'd like to propose the same approach for Horizon.

** Affects: horizon
     Importance: Undecided
         Status: New

** Description changed:

  It was reported on Safari browser: if some parts of the page are already
  loaded (including some buttons with ajax-modal class), then the click on
  the ajax-modal button before the js-handler for .ajax-modal is loaded
  will cause non-ajax request, which will probably fail if no special
- template for ajax request was provided.
+ template for non-ajax request was provided.
  
  One solution is to provide non-ajax template for each .ajax-modal link
  for that case - but it seems a bit ugly to me (no fun in showing non-
  modal form where a modal one should be).
  
  The solution I've adopted in Murano for that problem is to temporarily
  disable all clicks until the page is finally loaded (with a transparent
  div covering all the <body> contents, which is hidden once page is
  loaded). I'd like to propose the same approach for Horizon.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1328540

Title:
  Clicks on ajax-modal buttons won't work as expected until portion of
  code from horizon.modals.js is loaded

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  It was reported on Safari browser: if some parts of the page are
  already loaded (including some buttons with ajax-modal class), then
  the click on the ajax-modal button before the js-handler for .ajax-
  modal is loaded will cause non-ajax request, which will probably fail
  if no special template for non-ajax request was provided.

  One solution is to provide non-ajax template for each .ajax-modal link
  for that case - but it seems a bit ugly to me (no fun in showing non-
  modal form where a modal one should be).

  The solution I've adopted in Murano for that problem is to temporarily
  disable all clicks until the page is finally loaded (with a
  transparent div covering all the <body> contents, which is hidden once
  page is loaded). I'd like to propose the same approach for Horizon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1328540/+subscriptions


Follow ups

References