← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1329415] [NEW] pagination and fixed filter will not work together

 

Public bug reported:

Steps to Reproduce:

1. Have several images
I have 2 Public and 5 Project images as displayed in Admin > Images.  Please see (A) in attachment.
2. Now if you go to Project > Images, you will see at the top 3 buttons.  For me it says: Project (5), Shared With Me (0) and Public (2)
3. If you click on those, they will show you the images in those categories (see (B) in attachment)

4. Now, check-out this patch: https://bugs.launchpad.net/horizon/+bug/1252649 to enable pagination on Project > Images
5. Go to Settings and set Items Per Page to 2
6. On Project > Images, it says Project (2), Shared With Me (0) and Public (1)  (see (C) in attachment)

=> This is not accurate though.  This is applying those filters on the
*current items* displayed on the page.  With pagination enabled those
are only 2 items.

Questions:
Do we want to pagination and fixed filter to work together?  Or just stick with what we have now (even though Glance supports pagination)?

Possible solution:
I don't think we should use the FixedFilter.  It seems like we plan on eventually supporting filtering by column and if we have both FixedFilter and Filter - that would be confusing.  Maybe we can add a 'Category' column and have Project, Shared with Me and Public as entries.  Then have a dropdown menu with the choice 'Category.'  This would be align with the Admin > Instances filter. Something like this?

** Affects: horizon
     Importance: Undecided
         Status: New

** Attachment added: "Untitled.png"
   https://bugs.launchpad.net/bugs/1329415/+attachment/4130527/+files/Untitled.png

** Summary changed:

- pagination and fixed filter do not work together
+ pagination and fixed filter will not work together

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1329415

Title:
  pagination and fixed filter will not work together

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Steps to Reproduce:

  1. Have several images
  I have 2 Public and 5 Project images as displayed in Admin > Images.  Please see (A) in attachment.
  2. Now if you go to Project > Images, you will see at the top 3 buttons.  For me it says: Project (5), Shared With Me (0) and Public (2)
  3. If you click on those, they will show you the images in those categories (see (B) in attachment)

  4. Now, check-out this patch: https://bugs.launchpad.net/horizon/+bug/1252649 to enable pagination on Project > Images
  5. Go to Settings and set Items Per Page to 2
  6. On Project > Images, it says Project (2), Shared With Me (0) and Public (1)  (see (C) in attachment)

  => This is not accurate though.  This is applying those filters on the
  *current items* displayed on the page.  With pagination enabled those
  are only 2 items.

  Questions:
  Do we want to pagination and fixed filter to work together?  Or just stick with what we have now (even though Glance supports pagination)?

  Possible solution:
  I don't think we should use the FixedFilter.  It seems like we plan on eventually supporting filtering by column and if we have both FixedFilter and Filter - that would be confusing.  Maybe we can add a 'Category' column and have Project, Shared with Me and Public as entries.  Then have a dropdown menu with the choice 'Category.'  This would be align with the Admin > Instances filter. Something like this?

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1329415/+subscriptions


Follow ups

References