yahoo-eng-team team mailing list archive

[Stuart McLaren <1334196@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

This change:

https://review.openstack.org/#/c/98722/

Introduces a new system style swift scheme: swift+config

A new function "validate_location" verifies that that scheme is not being set by a user
when using the 'set location' functionality.

However, that function will only perform that check if the default backend is swift.
If the swift store is enabled but the default store is 'ceph' say then the base
version of that function (which performs no checking) will be called.

I think 'validate_location' should probably be removed and a check against 'swift+config' should
be performed in _validate_source, in the same way as 'file' is checked there.

** Affects: glance
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1334196

Title:
  User may be able to set 'system' style swift location

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  This change:

  https://review.openstack.org/#/c/98722/

  Introduces a new system style swift scheme: swift+config

  A new function "validate_location" verifies that that scheme is not being set by a user
  when using the 'set location' functionality.

  However, that function will only perform that check if the default backend is swift.
  If the swift store is enabled but the default store is 'ceph' say then the base
  version of that function (which performs no checking) will be called.

  I think 'validate_location' should probably be removed and a check against 'swift+config' should
  be performed in _validate_source, in the same way as 'file' is checked there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1334196/+subscriptions