yahoo-eng-team team mailing list archive

[Peter Belanyi <pbelanyi@xxxxxxxxxx>]

Public bug reported:

Running the jshint codeanalysis tool for javascript on the horizon
codebase found 10 errors:

horizon/static/horizon/js/horizon.d3linechart.js: line 415, col 11, It's not necessary to initialize 'last_point' to 'undefined'.
horizon/static/horizon/js/horizon.d3linechart.js: line 415, col 35, It's not necessary to initialize 'last_point_color' to 'undefined'.

horizon/static/horizon/js/horizon.d3piechart.js: line 145, col 10, ['key'] is better written in dot notation.
horizon/static/horizon/js/horizon.d3piechart.js: line 146, col 10, ['value'] is better written in dot notation.
horizon/static/horizon/js/horizon.d3piechart.js: line 162, col 44, ['value'] is better written in dot notation.
horizon/static/horizon/js/horizon.d3piechart.js: line 236, col 27, ['key'] is better written in dot notation.
horizon/static/horizon/js/horizon.d3piechart.js: line 237, col 33, ['value'] is better written in dot notation.

horizon/static/horizon/js/horizon.forms.js: line 8, col 26, Use '===' to compare with ''.
horizon/static/horizon/js/horizon.forms.js: line 25, col 26, Use '===' to compare with ''.
horizon/static/horizon/js/horizon.forms.js: line 42, col 26, Use '===' to compare with ''.


The exact commands:
jshint horizon/static/horizon/js
jshint horizon/static/horizon/tests

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1334622

Title:
  Javascript issues found by jshint

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Running the jshint codeanalysis tool for javascript on the horizon
  codebase found 10 errors:

  horizon/static/horizon/js/horizon.d3linechart.js: line 415, col 11, It's not necessary to initialize 'last_point' to 'undefined'.
  horizon/static/horizon/js/horizon.d3linechart.js: line 415, col 35, It's not necessary to initialize 'last_point_color' to 'undefined'.

  horizon/static/horizon/js/horizon.d3piechart.js: line 145, col 10, ['key'] is better written in dot notation.
  horizon/static/horizon/js/horizon.d3piechart.js: line 146, col 10, ['value'] is better written in dot notation.
  horizon/static/horizon/js/horizon.d3piechart.js: line 162, col 44, ['value'] is better written in dot notation.
  horizon/static/horizon/js/horizon.d3piechart.js: line 236, col 27, ['key'] is better written in dot notation.
  horizon/static/horizon/js/horizon.d3piechart.js: line 237, col 33, ['value'] is better written in dot notation.

  horizon/static/horizon/js/horizon.forms.js: line 8, col 26, Use '===' to compare with ''.
  horizon/static/horizon/js/horizon.forms.js: line 25, col 26, Use '===' to compare with ''.
  horizon/static/horizon/js/horizon.forms.js: line 42, col 26, Use '===' to compare with ''.

  
  The exact commands:
  jshint horizon/static/horizon/js
  jshint horizon/static/horizon/tests

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1334622/+subscriptions