yahoo-eng-team team mailing list archive

[Wei Wang <damon.devops@xxxxxxxxx>]

Public bug reported:

In the function neutron.db.l3_db.get_assoc_data(),
we get router_id first, then check whether this router is connecting to external network.

But the function we used to get router_id --
neutron.db.l3_db._get_router_for_floatingip(), has already checked this.

As it names says, this function is designed for get router_id, which can
connect to floating network.

** Affects: neutron
     Importance: Undecided
     Assignee: Wei Wang (damon-devops)
         Status: New

** Description changed:

  In the function neutron.db.l3_db.get_assoc_data(),
+ we get router_id first, then check whether this router is connecting to external network.
  
- we get router_id first, then check whether this router is connecting to
- external network.
+ But the function we used to get router_id -- neutron.db.l3_db._get_router_for_floatingip(),
+ has already checked this. 
  
- But the function we used to get router_id --
- neutron.db.l3_db._get_router_for_floatingip(),
- 
- has already checked this. as it names says, this function is designed
- for get router_id, which can
- 
+ As it names says, this function is designed for get router_id, which can
  connect to floating network.

** Description changed:

  In the function neutron.db.l3_db.get_assoc_data(),
  we get router_id first, then check whether this router is connecting to external network.
  
- But the function we used to get router_id -- neutron.db.l3_db._get_router_for_floatingip(),
- has already checked this. 
+ But the function we used to get router_id --
+ neutron.db.l3_db._get_router_for_floatingip(), has already checked this.
  
  As it names says, this function is designed for get router_id, which can
  connect to floating network.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1353414

Title:
  duplicated check for router connect to external network

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  In the function neutron.db.l3_db.get_assoc_data(),
  we get router_id first, then check whether this router is connecting to external network.

  But the function we used to get router_id --
  neutron.db.l3_db._get_router_for_floatingip(), has already checked
  this.

  As it names says, this function is designed for get router_id, which
  can connect to floating network.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1353414/+subscriptions