yahoo-eng-team team mailing list archive

[Randy Bertram <rbertram@xxxxxxxxxx>]

Public bug reported:

In horizon/static/horizon/js/angular/horizon.js, there is no
encapsulation. The variables horizon_dependencies and dependencies are
only used locally, but are placed in the global namespace. Encapsulating
the file would also allow for strict mode.

(The variable horizonApp has to be placed in the global namespace, since
it is referenced elsewhere. It should perhaps be eliminated in favor of
just referencing angular.module('hz'), but that is a different issue.)

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1354120

Title:
  angular/horizon.js puts vars in global namespace

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  In horizon/static/horizon/js/angular/horizon.js, there is no
  encapsulation. The variables horizon_dependencies and dependencies are
  only used locally, but are placed in the global namespace.
  Encapsulating the file would also allow for strict mode.

  (The variable horizonApp has to be placed in the global namespace,
  since it is referenced elsewhere. It should perhaps be eliminated in
  favor of just referencing angular.module('hz'), but that is a
  different issue.)

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1354120/+subscriptions