yahoo-eng-team team mailing list archive

[Vish Ishaya <vishvananda@xxxxxxxxx>]

Public bug reported:

Various nova extensions commands return a text response ("202 Accepted
[..]") even when provided with an "Accept: application/json" header. For
other 202 responses, either an empty body or a JSON-formatted response
is standard. The implementation should be consistent with other 202's
from Nova and other OpenStack Services.

This seems to be due to returning a webob exception instead of a response. The affected extensions are:
$ grep HTTPAccepted nova/api/openstack/compute/contrib/*.py
nova/api/openstack/compute/contrib/cloudpipe_update.py:        return webob.exc.HTTPAccepted()
nova/api/openstack/compute/contrib/fixed_ips.py:        return webob.exc.HTTPAccepted()
nova/api/openstack/compute/contrib/networks_associate.py:        return exc.HTTPAccepted()
nova/api/openstack/compute/contrib/networks_associate.py:        return exc.HTTPAccepted()
nova/api/openstack/compute/contrib/networks_associate.py:        return exc.HTTPAccepted()
nova/api/openstack/compute/contrib/os_networks.py:        return exc.HTTPAccepted()
nova/api/openstack/compute/contrib/os_networks.py:        return exc.HTTPAccepted()
nova/api/openstack/compute/contrib/os_tenant_networks.py:            response = exc.HTTPAccepted()

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1356058

Title:
  Various extensions don't respect content header when returning a 202

Status in OpenStack Compute (Nova):
  New

Bug description:
  Various nova extensions commands return a text response ("202 Accepted
  [..]") even when provided with an "Accept: application/json" header.
  For other 202 responses, either an empty body or a JSON-formatted
  response is standard. The implementation should be consistent with
  other 202's from Nova and other OpenStack Services.

  This seems to be due to returning a webob exception instead of a response. The affected extensions are:
  $ grep HTTPAccepted nova/api/openstack/compute/contrib/*.py
  nova/api/openstack/compute/contrib/cloudpipe_update.py:        return webob.exc.HTTPAccepted()
  nova/api/openstack/compute/contrib/fixed_ips.py:        return webob.exc.HTTPAccepted()
  nova/api/openstack/compute/contrib/networks_associate.py:        return exc.HTTPAccepted()
  nova/api/openstack/compute/contrib/networks_associate.py:        return exc.HTTPAccepted()
  nova/api/openstack/compute/contrib/networks_associate.py:        return exc.HTTPAccepted()
  nova/api/openstack/compute/contrib/os_networks.py:        return exc.HTTPAccepted()
  nova/api/openstack/compute/contrib/os_networks.py:        return exc.HTTPAccepted()
  nova/api/openstack/compute/contrib/os_tenant_networks.py:            response = exc.HTTPAccepted()

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1356058/+subscriptions