yahoo-eng-team team mailing list archive

[Paul Michali <1358470@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The unit test module for the Cisco CSR REST client was written to use
the httmock package for Icehouse. However, this was disabled (named
notest_cisco_csr_rest.py), as the community decision was to not add the
httmock package. There also was discussion about replacing the other
(approved) package, httpretty. Because of that, no activity was
performed on this unit test module.

Since, Icehouse, a new package requests_mock was added to global
requirements, and work is on-going to migrate httpretty use to this new
package.

This bug is to update the notest_cisco_csr_rest.py module to work with
the requests_mock package. A companion bug will be created to add
requests_mock to the Neutron test-requirements.txt (not sure why it
wasn't automatically added).

This will allow coverage of the REST client code for VPNaaS.

** Affects: neutron
     Importance: Undecided
     Assignee: Paul Michali (pcm)
         Status: In Progress


** Tags: vpnaas

** Changed in: neutron
     Assignee: (unassigned) => Paul Michali (pcm)

** Changed in: neutron
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1358470

Title:
  VPNaaS modify Cisco REST client UTs to use requests-mock library

Status in OpenStack Neutron (virtual network service):
  In Progress

Bug description:
  The unit test module for the Cisco CSR REST client was written to use
  the httmock package for Icehouse. However, this was disabled (named
  notest_cisco_csr_rest.py), as the community decision was to not add
  the httmock package. There also was discussion about replacing the
  other (approved) package, httpretty. Because of that, no activity was
  performed on this unit test module.

  Since, Icehouse, a new package requests_mock was added to global
  requirements, and work is on-going to migrate httpretty use to this
  new package.

  This bug is to update the notest_cisco_csr_rest.py module to work with
  the requests_mock package. A companion bug will be created to add
  requests_mock to the Neutron test-requirements.txt (not sure why it
  wasn't automatically added).

  This will allow coverage of the REST client code for VPNaaS.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1358470/+subscriptions