yahoo-eng-team team mailing list archive

[Akihiro Motoki <1362784@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Various plugins have get_port_from_devices (or get_port_and_sgs) for Security Group server side RPC callback.
However these methods are 99% same and only differences are:
-  "== port_id" vs ".startswith(port_id)", and
- how to get port_id from the passed "device" (netdev name for linuxbridge and port-id for OVS)

Such code duplication should be removed.

** Affects: neutron
     Importance: Low
     Assignee: Akihiro Motoki (amotoki)
         Status: New


** Tags: sg-fw

** Changed in: neutron
     Assignee: amo (amo) => Akihiro Motoki (amotoki)

** Changed in: neutron
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1362784

Title:
  Should remove duplicated get_port_from_device method in various
  plugins

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  Various plugins have get_port_from_devices (or get_port_and_sgs) for Security Group server side RPC callback.
  However these methods are 99% same and only differences are:
  -  "== port_id" vs ".startswith(port_id)", and
  - how to get port_id from the passed "device" (netdev name for linuxbridge and port-id for OVS)

  Such code duplication should be removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1362784/+subscriptions