← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1158501] Re: Modal upload forms with FileField revert to un-modal on validation error

 

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1158501

Title:
  Modal upload forms with FileField revert to un-modal on validation
  error

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Any modal form which contains a FileField will revert to being non-
  modal when the form is re-displayed for a validation error.

  Currently this would affect the following forms:
  Images and Snapshots -> Create Image
  Containers -> Upload Object

  This is happening because the ajax POST technique doesn't work for
  enctype="multipart/form-data" forms.

  A short term workaround could be to start these forms as non-modal,
  even though this isn't consistent with the look of other forms, is
  less disconcerting than triggering this bug.

  A long term fix would be to implement ajax uploading (google 'django
  ajax upload'), which may be worthy of a blueprint.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1158501/+subscriptions