yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1360279

Title:
  Some LBaaS API test returns wrong data

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In some LBaaS API test, mocked neutronclient API returns Horizon
  internal objects instead of a dictionary returned from neutronclient.

  diff --git a/openstack_dashboard/test/api_tests/lbaas_tests.py b/openstack_dashboard/test/api_tests/lbaas_tests.py
  index f393e2a..e0cf693 100644
  --- a/openstack_dashboard/test/api_tests/lbaas_tests.py
  +++ b/openstack_dashboard/test/api_tests/lbaas_tests.py
  @@ -57,7 +57,8 @@ class LbaasApiTests(test.APITestCase):
                           'admin_state_up': vip1['admin_state_up']
                           }

  -        neutronclient.create_vip({'vip': vipform_data}).AndReturn(vipform_data)
  +        neutronclient.create_vip({'vip': vipform_data}).AndReturn(
  +            {'vip': vipform_data})
           self.mox.ReplayAll()

           form_data = dict(vipform_data)
  @@ -196,9 +197,9 @@ class LbaasApiTests(test.APITestCase):
           api.neutron.subnet_get(self.request, subnet.id).AndReturn(subnet)
           neutronclient.show_vip(pool.vip_id).AndReturn(vip_dict)
           neutronclient.list_members(pool_id=pool.id).AndReturn(
  -            {'members': self.members.list()})
  +            {'members': self.api_members.list()})
           neutronclient.list_health_monitors(id=pool.health_monitors).AndReturn(
  -            {'health_monitors': [self.monitors.first()]})
  +            {'health_monitors': [self.api_monitors.first()]})
           self.mox.ReplayAll()

           ret_val = api.lbaas.pool_get(self.request, pool.id)

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1360279/+subscriptions