yahoo-eng-team team mailing list archive

[Michael Davies <michael@xxxxxxxxxxxxxx>]

** Also affects: python-cliff
   Importance: Undecided
       Status: New

** Changed in: python-cliff
     Assignee: (unassigned) => Michael Davies (mrda)

** Changed in: python-cliff
       Status: New => In Progress

** Description changed:

- 
  mock.assert_called_once() is a noop, it doesn't test anything.
  
  Instead it should be mock.assert_called_once_with()
  
  This occurs in the following places:
-   nova/tests/virt/hyperv/test_ioutils.py
-   nova/tests/virt/libvirt/test_driver.py
+   Nova
+     nova/tests/virt/hyperv/test_ioutils.py
+     nova/tests/virt/libvirt/test_driver.py
+   Cliff
+     cliff/tests/test_app.py

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1365751

Title:
  Use of assert_called_once() instead of assert_called_once_with()

Status in OpenStack Compute (Nova):
  In Progress
Status in Command Line Interface Formulation Framework:
  In Progress

Bug description:
  mock.assert_called_once() is a noop, it doesn't test anything.

  Instead it should be mock.assert_called_once_with()

  This occurs in the following places:
    Nova
      nova/tests/virt/hyperv/test_ioutils.py
      nova/tests/virt/libvirt/test_driver.py
    Cliff
      cliff/tests/test_app.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1365751/+subscriptions