yahoo-eng-team team mailing list archive

[Michael Davies <michael@xxxxxxxxxxxxxx>]

Public bug reported:


mock.assert_called_once() is a noop, it doesn't test anything.

Instead it should be mock.assert_called_once_with()

This occurs in the following places:
  nova/tests/virt/hyperv/test_ioutils.py
  nova/tests/virt/libvirt/test_driver.py

** Affects: nova
     Importance: Undecided
     Assignee: Michael Davies (mrda)
         Status: In Progress

** Changed in: nova
     Assignee: (unassigned) => Michael Davies (mrda)

** Changed in: nova
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1365751

Title:
  Use of assert_called_once() instead of assert_called_once_with()

Status in OpenStack Compute (Nova):
  In Progress

Bug description:
  
  mock.assert_called_once() is a noop, it doesn't test anything.

  Instead it should be mock.assert_called_once_with()

  This occurs in the following places:
    nova/tests/virt/hyperv/test_ioutils.py
    nova/tests/virt/libvirt/test_driver.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1365751/+subscriptions