yahoo-eng-team team mailing list archive

[Rushi Agrawal <rushi.openstack@xxxxxxxxx>]

Public bug reported:

When I make this change

http://paste.openstack.org/show/106339/

to unit tests, the test fails. key3=a key-value pair is matched, but it
shouldn't be.

Also, there is no test case for different values of filter, except empty
filter.

The problem is , the def _match_any() is not checking if pattern_list is
actually a list, or just a string.

The solution will be to add a condition "pattern_list = [pattern_list]
if isinstance(pattern_list, str)"

Unit tests also must be added

** Affects: nova
     Importance: Undecided
     Assignee: Rushi Agrawal (rushiagr)
         Status: New


** Tags: low-hanging-fruit

** Description changed:

- When I make this change to unit tests, the test fails. key3=a key-value
- pair is matched, but it shouldn't be.
+ When I make this change
+ 
+ http://paste.openstack.org/show/106339/
+ 
+ to unit tests, the test fails. key3=a key-value pair is matched, but it
+ shouldn't be.
  
  Also, there is no test case for different values of filter, except empty
  filter.
  
  The problem is , the def _match_any() is not checking if pattern_list is
  actually a list, or just a string.
  
  The solution will be to add a condition "pattern_list = [pattern_list]
  if isinstance(pattern_list, str)"
  
  Unit tests also must be added

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1365887

Title:
  Metadata filtering is broken

Status in OpenStack Compute (Nova):
  New

Bug description:
  When I make this change

  http://paste.openstack.org/show/106339/

  to unit tests, the test fails. key3=a key-value pair is matched, but
  it shouldn't be.

  Also, there is no test case for different values of filter, except
  empty filter.

  The problem is , the def _match_any() is not checking if pattern_list
  is actually a list, or just a string.

  The solution will be to add a condition "pattern_list = [pattern_list]
  if isinstance(pattern_list, str)"

  Unit tests also must be added

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1365887/+subscriptions