← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1293938] Re: nova.image.glance unit tests should not use fake glance service

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => juno-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1293938

Title:
  nova.image.glance unit tests should not use fake glance service

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  The unit tests in nova.tests.image.test_glance unfortunately make use
  of a faked glance image service in nova.tests.image.fakes. What this
  does is actually mask a number of problems and makes it harder to
  assert for specific behavior in the real glanceclient client classes.

  The unit tests should be rewritten to simply mock out the very
  specific code boundaries where tested calls interact with the
  glanceclient client classes, and that's it. Unit tests should just
  test one little unit of code, not giant swathes of dependent code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1293938/+subscriptions


References