← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1367442] [NEW] project > images fixed filter is missing icons

 

Public bug reported:

Project | Shared with Me | Public ==> should have icons beside each
filter choice as it did before bootstrap 3 update.

https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_data_table_table_actions.html#L7

code:
{% if button.icon %}<i class="{{ button.icon }}"></i>

With Bootstrap 3 update, we should be using... class="glyphicon
glyphicon-star" for icons instead of <i>

** Affects: horizon
     Importance: Undecided
     Assignee: Cindy Lu (clu-m)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Cindy Lu (clu-m)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1367442

Title:
  project > images fixed filter is missing icons

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Project | Shared with Me | Public ==> should have icons beside each
  filter choice as it did before bootstrap 3 update.

  https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_data_table_table_actions.html#L7

  code:
  {% if button.icon %}<i class="{{ button.icon }}"></i>

  With Bootstrap 3 update, we should be using... class="glyphicon
  glyphicon-star" for icons instead of <i>

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1367442/+subscriptions


Follow ups

References