yahoo-eng-team team mailing list archive

[Samuel de Medeiros Queiroz <samuel@xxxxxxxxxxxxxxx>]

Public bug reported:

When getting or deleting a grant, if something goes wrong, a
RoleNotFound exception is thrown. [1]-[6]

In cases where the role exists and the combination of other arguments is
invalid, this is a non-suggestive exception because it tells us "Could
not find role: %(role_id)s".

We should create a new exception called GrantNotFound and use it in
those cases.

[1] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/sql.py#L201-L202
[2] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/sql.py#L219-L220

[3] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/kvs.py#L527-L528
[4] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/kvs.py#L549-L550

[5] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/ldap.py#L353-L354
[6] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/ldap.py#L381-L382

** Affects: keystone
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1367740

Title:
  Assignment backends raise non-suggestive exception in grant CRUD

Status in OpenStack Identity (Keystone):
  New

Bug description:
  When getting or deleting a grant, if something goes wrong, a
  RoleNotFound exception is thrown. [1]-[6]

  In cases where the role exists and the combination of other arguments
  is invalid, this is a non-suggestive exception because it tells us
  "Could not find role: %(role_id)s".

  We should create a new exception called GrantNotFound and use it in
  those cases.

  [1] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/sql.py#L201-L202
  [2] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/sql.py#L219-L220

  [3] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/kvs.py#L527-L528
  [4] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/kvs.py#L549-L550

  [5] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/ldap.py#L353-L354
  [6] https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/ldap.py#L381-L382

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1367740/+subscriptions