← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1368939] [NEW] server-create API doesn't handle _validate_bdm failures

 

Public bug reported:

This came up here:

https://review.openstack.org/#/c/116837/3/nova/api/openstack/compute/plugins/v3/servers.py

The compute API's _validate_bdm method can raise up
CinderConnectionFailed or InvalidBDM exceptions and they aren't handled
in the server create nova API extension.  They'll just be turned into
500 errors in the response.

InvalidBDM should probably be a 400.

CinderConnectionFailed should probably remain a 500 since we could fail
that due to cinder being down (503), auth issues (401 or 403), etc.  The
reason for the failure is in that exception so it's not as big a deal.

** Affects: nova
     Importance: Undecided
         Status: Triaged


** Tags: api volumes

** Changed in: nova
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1368939

Title:
  server-create API doesn't handle _validate_bdm failures

Status in OpenStack Compute (Nova):
  Triaged

Bug description:
  This came up here:

  https://review.openstack.org/#/c/116837/3/nova/api/openstack/compute/plugins/v3/servers.py

  The compute API's _validate_bdm method can raise up
  CinderConnectionFailed or InvalidBDM exceptions and they aren't
  handled in the server create nova API extension.  They'll just be
  turned into 500 errors in the response.

  InvalidBDM should probably be a 400.

  CinderConnectionFailed should probably remain a 500 since we could
  fail that due to cinder being down (503), auth issues (401 or 403),
  etc.  The reason for the failure is in that exception so it's not as
  big a deal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1368939/+subscriptions


Follow ups

References