yahoo-eng-team team mailing list archive

[Daniel Berrange <1369516@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

A large number of libvirt test classes inherit from the TestCase class,
which means they incur the overhead of database setup

nova/tests/virt/libvirt/test_blockinfo.py:class LibvirtBlockInfoTest(test.TestCase):
nova/tests/virt/libvirt/test_blockinfo.py:class DefaultDeviceNamesTestCase(test.TestCase):
nova/tests/virt/libvirt/test_dmcrypt.py:class LibvirtDmcryptTestCase(test.TestCase):
nova/tests/virt/libvirt/test_driver.py:class CacheConcurrencyTestCase(test.TestCase):
nova/tests/virt/libvirt/test_driver.py:class LibvirtConnTestCase(test.TestCase,
nova/tests/virt/libvirt/test_driver.py:class HostStateTestCase(test.TestCase):
nova/tests/virt/libvirt/test_driver.py:class IptablesFirewallTestCase(test.TestCase):
nova/tests/virt/libvirt/test_driver.py:class NWFilterTestCase(test.TestCase):
nova/tests/virt/libvirt/test_driver.py:class LibvirtUtilsTestCase(test.TestCase):
nova/tests/virt/libvirt/test_driver.py:class LibvirtDriverTestCase(test.TestCase):
nova/tests/virt/libvirt/test_driver.py:class LibvirtVolumeUsageTestCase(test.TestCase):
nova/tests/virt/libvirt/test_driver.py:class LibvirtNonblockingTestCase(test.TestCase):
nova/tests/virt/libvirt/test_driver.py:class LibvirtVolumeSnapshotTestCase(test.TestCase):
nova/tests/virt/libvirt/test_imagebackend.py:class EncryptedLvmTestCase(_ImageTestCase, test.TestCase):
nova/tests/virt/libvirt/test_vif.py:class LibvirtVifTestCase(test.TestCase):

Some of these do not even use the database so can be trivially changed.
Others will need significant refactoring work to remove database access
before they can be changed to NoDBTestCase

** Affects: nova
     Importance: Medium
     Assignee: Daniel Berrange (berrange)
         Status: Confirmed

** Changed in: nova
     Assignee: (unassigned) => Daniel Berrange (berrange)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1369516

Title:
  Convert libvirt driver test suites to use NoDBTestCase

Status in OpenStack Compute (Nova):
  Confirmed

Bug description:
  A large number of libvirt test classes inherit from the TestCase
  class, which means they incur the overhead of database setup

  nova/tests/virt/libvirt/test_blockinfo.py:class LibvirtBlockInfoTest(test.TestCase):
  nova/tests/virt/libvirt/test_blockinfo.py:class DefaultDeviceNamesTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_dmcrypt.py:class LibvirtDmcryptTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_driver.py:class CacheConcurrencyTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_driver.py:class LibvirtConnTestCase(test.TestCase,
  nova/tests/virt/libvirt/test_driver.py:class HostStateTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_driver.py:class IptablesFirewallTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_driver.py:class NWFilterTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_driver.py:class LibvirtUtilsTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_driver.py:class LibvirtDriverTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_driver.py:class LibvirtVolumeUsageTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_driver.py:class LibvirtNonblockingTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_driver.py:class LibvirtVolumeSnapshotTestCase(test.TestCase):
  nova/tests/virt/libvirt/test_imagebackend.py:class EncryptedLvmTestCase(_ImageTestCase, test.TestCase):
  nova/tests/virt/libvirt/test_vif.py:class LibvirtVifTestCase(test.TestCase):

  Some of these do not even use the database so can be trivially
  changed. Others will need significant refactoring work to remove
  database access before they can be changed to NoDBTestCase

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1369516/+subscriptions